in ns_wait_for_socket() it is possible to return an uninitialized "ret" if socket() returns failure ... so attached patch sets it to -1 at start ... side node, shouldnt that tmp_sock > 0 be >= 0 ? in reality it'll prob never be 0, but a value of 0 from socket() is certainly not an error ...
in ns_ren_disp() it may be possible to pass an uninitialized "l" to the MALLOC() so attached patch sets it to 0 at start -mike
pgpAh0zSeh6tM.pgp
Description: PGP signature
Index: libscream.c
===================================================================
RCS file: /cvs/e/eterm/Eterm/src/libscream.c,v
retrieving revision 1.33
diff -u -p -r1.33 libscream.c
--- libscream.c 19 Sep 2006 21:07:40 -0000 1.33
+++ libscream.c 14 Oct 2006 05:14:36 -0000
@@ -1084,7 +1084,7 @@ ns_attach_lcl(_ns_sess ** sp)
static int
ns_wait_for_socket(int port)
{
- int tmp_sock, ret;
+ int tmp_sock, ret = -1;
time_t start_time;
D_ESCREEN(("Waiting for forwarder to begin listening on port %d.\n", port));
@@ -1933,7 +1933,7 @@ int
ns_ren_disp(_ns_sess * s, int d, char *name)
{
char *i = NULL, *n;
- size_t l;
+ size_t l = 0;
int ret = NS_FAIL;
if (!s) {
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
