This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch span-gl-clean
in repository efl.
View the commit online.
commit 682856faa95a6c3395c3d2c2d04e1b26b936e7f2
Author: [email protected] <[email protected]>
AuthorDate: Wed May 6 12:07:47 2026 -0600
docs(evas_ector_gl): correct stale comments in span pipe-flush path
Fix three comment accuracy nits in _span_fill_vertices and
_span_pipe_find_or_alloc: remove cross-reference to deleted _span_draw_pass,
complete the merge predicate list (6 conditions, all explicitly named), and
clarify that span_inv_tw/th are pool reciprocals, not predicate fields.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
---
src/modules/evas/engines/gl_common/evas_gl_context.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/modules/evas/engines/gl_common/evas_gl_context.c b/src/modules/evas/engines/gl_common/evas_gl_context.c
index cc4b8858b4..265165d2a2 100644
--- a/src/modules/evas/engines/gl_common/evas_gl_context.c
+++ b/src/modules/evas/engines/gl_common/evas_gl_context.c
@@ -2108,7 +2108,8 @@ _span_fill_vertices(void *out_buf, Span_Variant variant,
{
const int idx[6] = { 0, 1, 2, 0, 2, 3 }; /* triangle fan indices into ndc_quad */
- /* Mask inv: 0=normal, 1=invert, derived from comp_method same as _span_draw_pass */
+ /* Mask inv: 0=normal, 1=invert. Derived from comp_method; methods 2
+ * and 4 invert the mask, others use the mask alpha directly. */
float mask_inv = 0.0f;
if (p->comp_method == 2 || p->comp_method == 4) mask_inv = 1.0f;
@@ -2250,8 +2251,9 @@ _span_fill_vertices(void *out_buf, Span_Variant variant,
/* Find an existing mergeable pipe entry or allocate a new one.
*
- * Task 4: merge predicate collapses from ~44 per-shape fields to 6:
- * variant, fill_tex, stroke_tex, grad_atlas_tex, mask_tex.
+ * The merge predicate collapses from ~44 per-shape fields to 6:
+ * region.type == SHD_SPAN, span_variant, span_fill_tex,
+ * span_stroke_tex, span_grad_atlas_tex, span_mask_tex.
* All other per-shape data is now embedded in the span_vertex_data buffer
* as per-vertex attributes, so it no longer participates in the predicate.
*
@@ -2293,7 +2295,11 @@ _span_pipe_find_or_alloc(Evas_Engine_GL_Context *gc,
}
#undef _S
- /* Store only the 5 predicate fields; per-shape data lives in vertex structs. */
+ /* Store the pool reciprocals: frame-constant scalars uploaded as uniforms
+ * at flush time. The 6 merge-predicate fields (variant, fill_tex,
+ * stroke_tex, grad_atlas_tex, mask_tex, region.type) are written by the
+ * caller after this returns, since they only need to be set on the path
+ * that allocates a fresh entry. */
gc->pipe[pn].shader.span_inv_tw = _inv_tw;
gc->pipe[pn].shader.span_inv_th = _inv_th;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
