[EGIT] [efl] 10/16: ecore_evas_sdl: properly handle evas ecore cleanup

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch evas-sdl3-rewrite
in repository efl.

View the commit online.

commit 07f621e17bec733bf80b3f4e303b90b3df706d84
Author: Swagtoy <m...@ow.swag.toys>
AuthorDate: Tue May 12 01:59:57 2026 -0400

    ecore_evas_sdl: properly handle evas ecore cleanup
    
    I was doing this all wrong and not actually freeing the ecore evas
    itself but the window. This meant the windows closed but
    EVAS_CALLBACK_DEL was not being called (saw it in Evisum).
    
    Signed-off-by: Swagtoy <m...@ow.swag.toys>
---
 src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c b/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
index cb4db6ca03..9957fbfda5 100644
--- a/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
+++ b/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
@@ -158,16 +158,11 @@ _ecore_evas_sdl_event_window_close(void *data EINA_UNUSED, int type EINA_UNUSED,
 { printf("%s\n", __FUNCTION__);
    Ecore_Sdl_Event_Window *ev = event;
    Ecore_Evas *ee;
-   Ecore_Evas_SDL_Switch_Data *swd;
    ee = _ecore_evas_sdl_match(ev->windowID);
    if (!ee)
      return ECORE_CALLBACK_PASS_ON;
 
-   swd = (Ecore_Evas_SDL_Switch_Data*) (ee + 1);
-   ecore_event_window_unregister(ev->windowID);
-   SDL_DestroyWindow(swd->w);
-   ee->prop.window     = 0;
-   swd->w = NULL;
+   ecore_evas_free(ee);
    return ECORE_CALLBACK_RENEW;
 }
 
@@ -219,7 +214,6 @@ _ecore_evas_sdl_free(Ecore_Evas *ee)
    Ecore_Evas_SDL_Switch_Data *swd = (Ecore_Evas_SDL_Switch_Data*) (ee + 1);
 
    ecore_event_window_unregister(SDL_GetWindowID(swd->w));
-
    SDL_DestroyWindow(swd->w);
 
    _ecore_evas_sdl_shutdown();
@@ -277,7 +271,7 @@ static void
 _ecore_evas_title_set(Ecore_Evas *ee, const char *t)
 { printf("%s %s\n", __FUNCTION__, t);
    Ecore_Evas_SDL_Switch_Data *swd = (Ecore_Evas_SDL_Switch_Data*)(ee + 1);
-   SDL_SetWindowTitle(swd->w, strfry(strdup(t ? t : "something")));
+   SDL_SetWindowTitle(swd->w, strfry(strdup(t ? t : "This code is really good")));
 }
 
 static Ecore_Evas_Engine_Func _ecore_sdl_engine_func =


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.