This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch evas-sdl3-rewrite
in repository efl.
View the commit online.
commit a31fa4cdc33fb23b4b41b0296bcda79f9032f57f
Author: Swagtoy <[email protected]>
AuthorDate: Thu May 14 14:10:03 2026 -0400
ecore_sdl: Set correct event window to allow for keypresses, set ev->key
Keys were not working due to ev->event_window being set to 0. And it
seemed to crash from ev->key not set. I might need to thoroughly
investigate SDL keypresses later but we'll see.
Signed-off-by: Swagtoy <[email protected]>
---
src/lib/ecore_sdl/ecore_sdl.c | 3 ++-
src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/lib/ecore_sdl/ecore_sdl.c b/src/lib/ecore_sdl/ecore_sdl.c
index 42581db1e8..55e0589fd7 100644
--- a/src/lib/ecore_sdl/ecore_sdl.c
+++ b/src/lib/ecore_sdl/ecore_sdl.c
@@ -142,7 +142,7 @@ _ecore_sdl_event_key(SDL_Event *event, double timestamp)
ev->timestamp = timestamp;
ev->window = event->key.windowID;
- ev->event_window = 0;
+ ev->event_window = event->key.windowID;
ev->modifiers = _ecore_sdl_event_modifiers(SDL_GetModState());
ev->key = NULL;
ev->compose = NULL;
@@ -152,6 +152,7 @@ _ecore_sdl_event_key(SDL_Event *event, double timestamp)
{
ev->keyname = keystable[i].name;
ev->string = keystable[i].compose;
+ ev->key = keystable[i].name;
return ev;
}
diff --git a/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c b/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
index 9ec169b359..c62ef3f399 100644
--- a/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
+++ b/src/modules/ecore_evas/engines/sdl/ecore_evas_sdl.c
@@ -257,14 +257,14 @@ static void
_ecore_evas_show(Ecore_Evas *ee)
{
Ecore_Evas_SDL_Data *edata = ee->engine.data;
-#if 0 // TODO: From the old old SDL code. What for? Hack?
+#if 0 // TODO: make this proper
ee->prop.withdrawn = EINA_FALSE;
if (ee->func.fn_state_change) ee->func.fn_state_change(ee);
#endif
SDL_ShowWindow(edata->w);
if (ee->func.fn_show) ee->func.fn_show(ee);
-#if 0 // TODO: From the old old SDL code. What for? Hack?
+#if 0 // TODO: make this proper focus event
if (ecore_evas_focus_device_get(ee, NULL)) return;
_ecore_evas_focus_device_set(ee, NULL, EINA_TRUE);
evas_event_feed_mouse_in(ee->evas, (unsigned int)((unsigned long long)(ecore_time_get() * 1000.0) & 0xffffffff), NULL);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
