This is an automated email from the git hooks/post-receive script.
git pushed a commit to reference refs/pull/114/head
in repository efl.
View the commit online.
commit b9ee1f47662c48f05884cc063ed03af3f405a5c6
Author: [email protected] <[email protected]>
AuthorDate: Sun Sep 13 22:16:38 2026 -0600
evas_vg: read the first composite source with eina_list_data_get()
The review pointed out that _prepare_comp() fetched the first composite
source with eina_list_nth(list, 0). Index 0 is the list head, so its data
is available directly through eina_list_data_get(list), without walking
the list.
Fix both copies of the _expression_:
- the GL mask path added by this branch;
- the software path it was copied from. That line comes from master and
is changed here on the reviewer's request, to keep both paths the same.
Behaviour is unchanged: both calls return the head's data, and NULL for
an empty list. The build is clean, and ector_suite and evas_suite pass.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
---
src/lib/evas/canvas/efl_canvas_vg_container.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/evas/canvas/efl_canvas_vg_container.c b/src/lib/evas/canvas/efl_canvas_vg_container.c
index e0bff55fdf..33d9f18ac8 100644
--- a/src/lib/evas/canvas/efl_canvas_vg_container.c
+++ b/src/lib/evas/canvas/efl_canvas_vg_container.c
@@ -139,7 +139,7 @@ _prepare_comp(Evas_Object_Protected_Data *obj, //vector object
{
Efl_Canvas_Vg_Container_Data *src_pd = NULL;
target_pd = efl_data_scope_get(ct, MY_CLASS);
- src_pd = efl_data_scope_get(eina_list_nth(target_pd->comp.src, 0), MY_CLASS);
+ src_pd = efl_data_scope_get(eina_list_data_get(target_pd->comp.src), MY_CLASS);
_evas_vg_render_pre(obj, ct,
engine, output, context, surface,
ctransform, c_opacity, NULL, src_pd->comp.method);
@@ -236,7 +236,7 @@ gl_mask_fallback:
{
Efl_Canvas_Vg_Container_Data *src_pd = NULL;
target_pd = efl_data_scope_get(comp_target, MY_CLASS);
- src_pd = efl_data_scope_get(eina_list_nth(target_pd->comp.src, 0), MY_CLASS);
+ src_pd = efl_data_scope_get(eina_list_data_get(target_pd->comp.src), MY_CLASS);
_evas_vg_render_pre(obj, comp_target,
engine, output, context, surface,
ctransform, c_opacity, comp, src_pd->comp.method);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
