On Mon, 18 Dec 2006 23:10:24 -0600 Ravenlock <[EMAIL PROTECTED]> babbled:
> On 12/18/2006 08:30, Ravenlock wrote: > > On 12/17/2006 19:55, Ravenlock wrote: > >> On 12/17/2006 10:00, Ravenlock wrote: > >>> Hello, > >>> > >>> Hoping for comments on the attached patch. > >>> > >>> The patch will add "Advanced" features to the Configuration Panel -> > >>> Screen -> Screen Lock panel. You can choose to override the "Lock > >>> Screen" functionality of E, and/or the E Screensaver with a "Custom > >>> Screensaver" which can be any executable you choose. > >>> > >> > >> A slight update. > >> > >> The only notable changes: > >> 1) I've changed the config dialog to use minutes in stead of seconds. > >> 2) Changed the range from 10 min max (600 seconds) to 90 minutes max. > >> 3) bumped the E_CONFIG_FILE_GENERATION from 0x105 to 0x106 > >> > > > > Final update until/unless there is some feedback. There may be no > > interest in this though I find it useful. > > > > Notable changes: > > 1) IPC code in place > > 2) Fixed memory leak wrt _e_config_free() > > > > Regards. > > > > Ok... really done this time... for now. I think this will suffice as a > first shot. (or is it my forth?) > > Either way, this last patch handles the X screensaver a bit better. I > think the functionality included in the patch will do what you would > think it should. > > Basically, you now can specify a single application that will respond > when you > - "Lock Screen" from the menu > - Use the "Desktop Lock" keybinding > - "Enable Screensaver" from the config panel. > > So... take a look. Comments welcome. Please don't forget to get the > shell script as well (prev post). I do not keep xscreensaver running.. > I use the script to launch it and shut it down. Saves a few bytes of > ram. Might be useful. > > Now, after doing this. I've come to the conclusion that a much better > job could be done. I could build a new configurator for the screensaver > itself. Seperate the desklock and the screensaver. That way in the > screensaver configuration, you could tweak the actual X screensaver > settings (timeout, cycletime, blank, expose) as well as DPMS settings. > And I could create seperate overrides, one for the desklock and one for > the screensaver. Just an idea. > > But I think what I have now might suffice for a while. > > Let me know what you think. I don't see any problem with this feature :) setting a command is ok- though what i think would be better is to have .desktop files with the screensaver commands and then just select from ones (maybe of Type=Screensaver) so you can pre-package configs for xscreensaver and other screensaver 3rd party apps out there. > >> Because of the E_CONFIG_FILE_GENERATION bump... please backup your E > >> config dir (just in case). I had something odd happen in the last > >> 24hrs (lost my config), and I'd hate for my patch to be responsible. > >> > >> I changed the max timeout because, while I feel 10 min is an > >> appropriate timeout (for me)... seems a bit restrictive. So I up'd it > >> a bit. > >> > >> Regards. > >> > >>> This is handy (I think). There have been some issues with PAM, while > >>> this is no fix for that... it does offer a suitable workaround. > >>> Especially for those of us who would choose to use things like > >>> xscreensaver in the first place. > >>> > >>> Yes, you can say "well just disable E's" and configure xscreensaver. > >>> But it was annoying to me that I could not "reconfigure" the lock > >>> function to use <insert_fav_screensaver_here>. And this makes the E > >>> interface feel a little more consistent, in the sense that now I can > >>> use the menu "Lock Scree" option, or keybindings to activate the > >>> screensaver app of my choosing. > >>> > >>> So, you can get a little creative with it. If you keep xscreensaver > >>> up and running , you might choose to use 'xscreensaver-command -lock' > >>> as your custom saver. This will lock the screen when you tell it to > >>> (using xscreensaver). Or (using the also attached script)... you > >>> could not run xscreensaver as a daemon, choose to use E's > >>> screensaver, override it using the new custom option, and allow E to > >>> manage the timer which starts xscreensaver. > >>> > >>> The GUI changes I've made are a bit suspect as there are conditional > >>> compilations (ifdef HAVE_PAM) that may affect the location of GUI > >>> components. if some who does not HAVE_PAM could comment, that would > >>> be great too. > >>> > >>> Anyway, I was hoping someone could give it a try and comment. > >>> > >>> > >>> ------------------------------------------------------------------------ > >>> > >>> ------------------------------------------------------------------------- > >>> > >>> Take Surveys. Earn Cash. Influence the Future of IT > >>> Join SourceForge.net's Techsay panel and you'll get the chance to > >>> share your > >>> opinions on IT & business topics through brief surveys - and earn cash > >>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > >>> > >>> > >>> > >>> ------------------------------------------------------------------------ > >>> > >>> _______________________________________________ > >>> enlightenment-devel mailing list > >>> enlightenment-devel@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > >> > > > > > > > -- > Regards, > Ravenlock > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel