Hello Enlightenment developers,
I've found a tiny bug in Enlightenment (compiled from the current
CVS source) and I hope this is the right place to post it.
Steps to reproduce:
Open the Main menu, select "Configuration", "Application Menus".
Select an an application without an icon from the "Available Applications".
Add the application to a menu (eg. favorite).
Select the new application in the "Menus" panel.
Right click and open "Properties".
Enlightenment crashes.
I ran it under gdb and it was caused by a simple null pointer
dereference so I've tested a quick fix and stops the crash (although I'm
not sure it's the correct thing to do because I've never looked at the
Enlightenment source code before). The patch is below (also thank you
all for working on enlightenment, it's great!).
Sam B.
diff -u -b -B -d -r1.15 e_widget.c
--- e_widget.c 16 Oct 2006 23:45:16 -0000 1.15
+++ e_widget.c 19 Jan 2007 15:42:34 -0000
@@ -146,7 +146,7 @@
{
if (e_widget_can_focus_get(sobj)) sd->child_can_focus = 1;
}
- if (!strcmp(evas_object_type_get(sobj), SMART_NAME))
+ if (evas_object_type_get(sobj) &&
!strcmp(evas_object_type_get(sobj), SMART_NAME))
{
sd = evas_object_smart_data_get(sobj);
if (sd) sd->parent_obj = obj;
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
