Sebastian Dransfeld wrote:
> Enlightenment CVS wrote:
>> Enlightenment CVS committal
>>
>> Author : devilhorns
>> Project : e17
>> Module : libs/edje
>>
>> Dir : e17/libs/edje/src/lib
>>
>>
>> Modified Files:
>> edje_util.c
>>
>>
>> Log Message:
>> Fix edje_color_class_list so that it's usable with enlightenment_remote
>> again.
>>
>> ===================================================================
>> RCS file: /cvs/e/e17/libs/edje/src/lib/edje_util.c,v
>> retrieving revision 1.86
>> retrieving revision 1.87
>> diff -u -3 -r1.86 -r1.87
>> --- edje_util.c 28 Dec 2006 11:35:40 -0000 1.86
>> +++ edje_util.c 1 Mar 2007 20:06:38 -0000 1.87
>> @@ -66,7 +66,6 @@
>> return _edje_fontset_append;
>> }
>>
>> -
>> /* FIXDOC: Verify/Expand */
>> /** Get Edje object data
>> * @param obj A valid Evas_Object handle
>> @@ -264,11 +263,12 @@
>> Evas_List *
>> edje_color_class_list(void)
>> {
>> - Edje_List_Foreach_Data fdata;
>> + Edje_List_Foreach_Data *fdata;
>>
>> - evas_hash_foreach(_edje_color_class_member_hash,
>> _edje_color_class_list_foreach, &fdata);
>> + fdata = calloc(1, sizeof(Edje_List_Foreach_Data));
>> + evas_hash_foreach(_edje_color_class_member_hash,
>> _edje_color_class_list_foreach, fdata);
>>
>> - return fdata.list;
>> + return fdata->list;
>
> And where do you free fdata? This fix is rubbish :)
>
> Sebastian
>
I beg to differ seb:
edje_util.c:
@return A list of color class names (strings). These strings and the list
* must be free()'d by the caller.
Check edje_text_class_list also...done exactly like that.
dh
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
