Could you elaborate why this change was made? It's just replacing a
temporary allocation on the stack with a temporary allocaiton on the
heap. The structure contents will still be allocated internally. I
could see a memset being necessary if the foreach function uses the
contents of fdata uninitialized.
On 3/1/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : libs/edje
>
> Dir : e17/libs/edje/src/lib
>
>
> Modified Files:
> edje_util.c
>
>
> Log Message:
> Properly fix edje_color_class_list.
>
> thanks Sebastion :)
>
> ===================================================================
> RCS file: /cvs/e/e17/libs/edje/src/lib/edje_util.c,v
> retrieving revision 1.87
> retrieving revision 1.88
> diff -u -3 -r1.87 -r1.88
> --- edje_util.c 1 Mar 2007 20:06:38 -0000 1.87
> +++ edje_util.c 1 Mar 2007 21:53:33 -0000 1.88
> @@ -264,11 +264,15 @@
> edje_color_class_list(void)
> {
> Edje_List_Foreach_Data *fdata;
> + Evas_List *list;
>
> fdata = calloc(1, sizeof(Edje_List_Foreach_Data));
> evas_hash_foreach(_edje_color_class_member_hash,
> _edje_color_class_list_foreach, fdata);
>
> - return fdata->list;
> + list = fdata->list;
> + free(fdata);
> +
> + return list;
> }
>
> static Evas_Bool
>
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> enlightenment-cvs mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
