On Thursday 29 March 2007 20:38:43 Tilman Sauerbeck wrote:
> Cedric BAIL [2007-03-29 17:58]:
> > Another little patch that potentially break every thing and need review.
> > To make the story short, when you have a lot of image on the screen with
> > many cliping, you are creating and destroying many time Cutout_Rect
> > object. So I changed the code to do less allocation/destruction. It also
> > break the API used by the engine, so a patch for them is needed.
>
> Looks good in general.
>
> I attached a modified version of your patch where I removed some
> oddities:
>
> In evas_common_draw_context_cutouts_del(), I renamed "delta" to "index".
> "delta" implies (for me) that it's the difference between two values,
> but it really is an index ;)
Indeed ! It was an "historical" name :)
> I also removed some unrelated changes that crept into the patch, like
> that "error_data" enum that wasn't referenced anywhere, and a few
> whitespace-only changes.
Hum, that's was a leak from another patch I am working on (a more complete
cache for font), but it is not really ready for prime time.
> Not sure whether I'm brave enough to commit this :)
:)
Thanks for your review !
Cedric
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
