Spotted a segv in the software_16 engine related to building the image
cache. I have an EWL engine setup to use software_16_x11, but EWL does
some aggressive evas object caching. In order to be certain edje
properties get reset, we set the file and key on the edje object to
NULL. As you can see in the function below, file is not checked to be
certain it's non-NULL before being used. Also, calling functions could
shortcut this key generation when the file is NULL.

On 6/18/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
>
> +static void
> +soft16_image_cache_key(const Evas_Image_Load_Opts *lo, const char *key,
> +                      const char *file, char *buf, unsigned bufsize)
> +{
> +   if ((!lo) ||
> +       ((lo->scale_down_by == 0) && (lo->dpi == 0.0) &&
> +       ((lo->w == 0) || (lo->h == 0))))
> +     {
> +       if (key) snprintf(buf, bufsize, "%s//://%s", file, key);
> +       else strncpy(buf, file, bufsize);
> +     }
> +   else
> +     {
> +       if (key)
> +          snprintf(buf, bufsize, "//@/%i/%1.5f/%ix%i//%s//://%s",
> +                   lo->scale_down_by, lo->dpi, lo->w, lo->h,
> +                   file, key);
> +       else
> +          snprintf(buf, bufsize, "//@/%i/%1.5f/%ix%i//%s",
> +                   lo->scale_down_by, lo->dpi, lo->w, lo->h,
> +                   file);
> +     }
> +}

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to