On 6/28/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : ningerso > Project : e17 > Module : libs/evas > > Dir : e17/libs/evas/src/modules/engines/software_16 > > > Modified Files: > evas_soft16_main.c > > > Log Message: > Prevent a segv when setting a image path to NULL. > > =================================================================== > RCS file: > /cvs/e/e17/libs/evas/src/modules/engines/software_16/evas_soft16_main.c,v > retrieving revision 1.9 > retrieving revision 1.10 > diff -u -3 -r1.9 -r1.10 > --- evas_soft16_main.c 21 Jun 2007 20:10:13 -0000 1.9 > +++ evas_soft16_main.c 28 Jun 2007 03:32:58 -0000 1.10 > @@ -185,6 +185,7 @@ > Soft16_Image *im; > char buf[4096 + 1024]; > > + if (!file) return NULL; > *error = 0; > soft16_image_cache_key(lo, key, file, buf, sizeof(buf)); > im = soft16_image_cache_get(buf);
it's not done in other parts of this code, but shouldn't we release/remove from cache when doing this? anyway, I need to review this cache stuff and do it properly to avoid keeping useless memory around... this is meant for embedded devices :-) -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
