Hi,
I found some minor bugs in etk+exhibit while playing with them
yesterday. Attached there are 2 patches to fix the bugs
The etk patch fixes a bug when reparenting a widget on an etk_box,
_etk_box_child_remove is freeing the newly created cell.
The exhibit patch fixes a bug where comment and len are unitialized
and _ex_comment_jpeg_read is returning true but without success "case
M_SOS:".
There is still one bug when you turn on/off show comments on the
preferences dialog, but i could not find it, as it does not happen all
the time.
BR
Andrunko
? src/lib/.etk_box.c.swp
Index: src/lib/etk_box.c
===================================================================
RCS file: /var/cvs/e/e17/libs/etk/src/lib/etk_box.c,v
retrieving revision 1.24
diff -u -r1.24 etk_box.c
--- src/lib/etk_box.c 25 Mar 2007 18:22:00 -0000 1.24
+++ src/lib/etk_box.c 10 Jul 2007 01:50:11 -0000
@@ -1046,8 +1046,8 @@
}
box->cells_count[group]++;
- etk_object_data_set(ETK_OBJECT(child), "_Etk_Box::Cell", cell);
etk_widget_parent_set(child, ETK_WIDGET(box));
+ etk_object_data_set(ETK_OBJECT(child), "_Etk_Box::Cell", cell);
etk_signal_emit_by_name("child-added", ETK_OBJECT(box), NULL, child);
}
? exhibit.log
? exhibit.log.1
Index: src/bin/exhibit_comment.c
===================================================================
RCS file: /var/cvs/e/e17/apps/exhibit/src/bin/exhibit_comment.c,v
retrieving revision 1.12
diff -u -r1.12 exhibit_comment.c
--- src/bin/exhibit_comment.c 1 Sep 2006 23:39:22 -0000 1.12
+++ src/bin/exhibit_comment.c 10 Jul 2007 01:51:54 -0000
@@ -70,8 +70,8 @@
_ex_comment_load(Exhibit *e)
{
char *file;
- char *comment;
- unsigned int len;
+ char *comment = NULL;
+ unsigned int len = 0;
file = ((Ex_Tab *) e->cur_tab)->cur_file;
if (_ex_file_is_jpg(file))
Index: src/bin/exhibit_main.c
===================================================================
RCS file: /var/cvs/e/e17/apps/exhibit/src/bin/exhibit_main.c,v
retrieving revision 1.114
diff -u -r1.114 exhibit_main.c
--- src/bin/exhibit_main.c 9 Jul 2007 23:50:41 -0000 1.114
+++ src/bin/exhibit_main.c 10 Jul 2007 01:51:57 -0000
@@ -890,7 +890,9 @@
char *homedir;
const char **dnd_types;
int dnd_types_num;
-
+
+ memset(file, 0, PATH_MAX);
+
e = calloc(1, sizeof(Exhibit));
e->mouse.down = 0;
e->menu = NULL;
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
