i made a little patch to misc/epbb for enlightenment 17.
now pbbuttonsd sends the backlight level tag already as a %, so
BACKLIGHT_MAX = 15 now is wrong
furthermore i edited the README to tell better the needed
file/directory, as the one mentioned there were wrong....

i thought also that when checking for resources (read: 'theme')
'return(NULL)' is not completely right, because the program starts,
then dies with "segmentation fault".
imho would be better to exit(1) immediatly...

i have put it the patch, too

bye, PaulTT

PS i already tried to contact atmos, but i get no answer....
bye again!
diff -urN epbb/src/bin/epbb.c epbb_ptt/src/bin/epbb.c
--- epbb/src/bin/epbb.c	2007-01-03 17:34:16.179675000 +0100
+++ epbb_ptt/src/bin/epbb.c	2007-06-22 21:14:55.498206139 +0200
@@ -65,7 +65,9 @@
             evas_object_del(result->obj);
             result->obj = NULL;
             free(result);
-            return (NULL);
+            // TODO: send out an error dialog box
+            fprintf(stderr, "Resource not found: %s, exiting.\n", buf);
+            exit(1);
          }
       }
       /* add our object */
@@ -181,7 +183,7 @@
 
    edje_object_signal_emit(e->obj, "pbb,display,brightness", "");
    epbb_progress_bar_percent_set(e, val);
-   snprintf(buf, 120, "%0.0f%%", 100 * (double) val);
+   snprintf(buf, 120, "%0.0f%%", val * 100 );
    epbb_status_text_set(e, buf);
 }
 
diff -urN epbb/src/bin/main.c epbb_ptt/src/bin/main.c
--- epbb/src/bin/main.c	2007-01-03 17:34:11.555675000 +0100
+++ epbb_ptt/src/bin/main.c	2007-06-22 21:15:26.586206139 +0200
@@ -24,7 +24,7 @@
 #include"../config.h"
 
 #define VOLUME_MAX 100
-#define BACKLIGHT_MAX 15
+#define BACKLIGHT_MAX 100
 
 #define UN(ptr) ptr = 0
 #define PBBUTTONSD_TIMEOUT 0.25
diff -urN epbb/README epbb_ptt/README
--- epbb/README	2004-01-20 11:19:36.000000000 +0100
+++ epbb_ptt/README	2007-06-22 21:18:33.834206139 +0200
@@ -16,10 +16,10 @@
 Install:
     sudo make install
 
-Configuration Files live in ~/.e/epbbuttons/ you need the following files
+Configuration Files live in ~/.e/apps/epbb/ you need the following files
 
-* default.bits.db - bits file for the window layout
-* font.ttf - the font for displaying text messages
+* epbb.eet - bits file for the window layout (theme)
+* directory fonts containing .ttf files - the font for displaying text messages
 
 Version 0.0.3 - I guess it's working.  Bugs and Patches to 
     - atmos at atmos dot org (May 8th 2003)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to