On Sun, 19 Aug 2007, Gustavo Sverzut Barbieri wrote:
>> Log Message:
>> use standard syntax when initializing structures instead of specific gcc one
>>
>> ===================================================================
>> RCS file: /cvs/e/e17/libs/evas/src/lib/engines/common/evas_tiler.c,v
>> retrieving revision 1.16
>> retrieving revision 1.17
>> diff -u -3 -r1.16 -r1.17
>> --- evas_tiler.c 8 Jun 2007 00:03:56 -0000 1.16
>> +++ evas_tiler.c 19 Aug 2007 06:21:23 -0000 1.17
>> @@ -2,8 +2,8 @@
>>
>> #ifdef EVAS_RECT_SPLIT
>>
>> -static const list_node_t list_node_zeroed = {.next = NULL};
>> -static const list_t list_zeroed = {.head = NULL, .tail = NULL};
>> +static const list_node_t list_node_zeroed = { NULL };
>> +static const list_t list_zeroed = { NULL, NULL };
>>
>>
>> typedef struct list_node_pool
>> @@ -13,9 +13,7 @@
>> int max;
>> } list_node_pool_t;
>>
>> -static list_node_pool_t list_node_pool = {
>> - .node = NULL, .len = 0, .max = 1024
>> -};
>> +static list_node_pool_t list_node_pool = { NULL, 0, 1024 };
>>
>> void
>> rect_list_node_pool_set_max(int max)
>
> No this is wrong, it's in C99 standard and is not a GCC extension:
>
> http://home.tiscalinet.ch/t_wolf/tw/c/c9x_changes.html
>
> I want to keep them since it help to avoid errors and helps readability.
avoid errors ? one structure has only 1 member, another 2 and another
3, the last one being declared just above. That's not a big deal to
maintain.
also, what convinces me to change that is that a guy, that wants to use
evas on win ce, with vc++, can't compile evas_tiler with that compiler. I
agree that vc++ is a bad compiler, but the changes are really minor.
Vincent
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
