On 9/12/07, Brett Nash <[EMAIL PROTECTED]> wrote:
> Hello All,
>
> A little set of patches to apply to evas (All are relative to
> ${E17ROOT}/libs/evas). They are (in no particular order):
>
> * freegc-crash.patch
> - Don't free a X11 GC unless we have one (software x11)
>
> * iindex-to-many-is.patch
> - Code checks *iindex is > 0, I assume it is meant to check that index
> is less then <= 0. Actually I wonder if it should read:
> if (index < 0)
>
> * c89-is-18-years-old-lets-use-it.patch
> - func() is the old style k&r declaration which means: Pass as many
> arguments as you damn well please, the compiler ain't checking...
>
> * kill-a-1-in-4-billion-crash.patch
> - Returning the lowest 32 bits of a pointer on a 64 bit arch to check
> for !NULL is not the best solution. Could also restructure instead.
> And it's probably not a crash, but it is a bug.
>
> * dereference-ints-all-bad.patch
> - Code puts a pointer in an int, does some maths on it, then
> dereference... all fine unless sizeof(void*)>sizeof(int). Use intptr_t
> instead, which is always >= sizeof(void*).
>
> * compare-whole-pointer.patch
> - This is mostly cleanliness (ie the code works, but it's not pretty).
> Once again use intptr_t instead of int for pointers.
>
> * mode-mem.patch
> - As above - but in a different file.
All applied individually, thanks.
--
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: [EMAIL PROTECTED]
MSN: [EMAIL PROTECTED]
ICQ#: 17249123
Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
