Hey All,

While reading through e_manager, I noticed 2 potential issues and wanted 
to ask about them before applying any fixes.

Issue 1)
------------------------
During e_manager_init, there is a call to 
ecore_x_screensaver_event_listen_set. I am assuming (without reading the 
code) that this call basically tells X screensaver to listen for events 
on this manager. The issue is that ecore_x_screensaver_event_listen_set 
is never called with a 0 to turn off listening when a manager gets 
free'd. (ie: e_manager_shutdown never calls it)

Issue 2)
------------------------
In _e_manager_cb_frame_extents_request I believe there is a typo. 
Basically an edje object gets created then we ask for the geometry of 
part "client"...shouldn't that be part "e.swallow.client" as is listed 
in the theme ?? (Code below)

             o = edje_object_add(con->bg_evas);
             snprintf(buf, sizeof(buf), "e/widgets/border/%s/border", border);
             ok = e_theme_edje_object_set(o, "base/theme/borders", buf);
             if (ok)
               {
                  Evas_Coord x, y, w, h;

                  if (signal)
                    {
                       edje_object_signal_emit(o, signal, "e");
                       edje_object_message_signal_process(o);
                    }

                  evas_object_resize(o, 1000, 1000);
                  edje_object_calc_force(o);
                  edje_object_part_geometry_get(o,"client",&x,&y,&w,&h);


Let me know if these should be corrected.

Thanks,
dh

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to