On Sat, 13 Oct 2007, Simon TRENY wrote:
>> PS: bugs may appear due Etk_Bool size change, values like 2 (10b) will >> now be evaluated as false. That was already a bug, just being exposed >> now, the fix is easy: use !! (double negative) before the value, >> example: "visible = obj_ptr;" becomes "visible = !!obj_ptr;". > > Can I ask you how many bytes per widget do you gain with such a change? > I don't really expect it to be more than 300b per widget. Since in an > Etk app, you'll most probably never have more than 300 widgets, you'll > gain 100kb max, and I'm being **VERY** generous here! :) And I don't > think 100kb is really important nowadays, even on embedded devices > (whose apps will never have 300 widgets anyway...). > > So, if you don't mind, I'm going to revert this change, as it > introduces code changes that I personally find really ugly (such > as "visible = !!obj_ptr;"...) > > And, it would have been great if this change had been discussed on the > dev ML before being committed. I know I haven't been really active > these last weeks, I've been quite busy with school and other projects, > but I'd still like to have the opportunity to give my opinion before > such a change happens. > > More generally, there has been a lot of important changes recently in > Etk internals, some of them are great, but there also have been changes > that I really don't like. I would have appreciated if you (i.e. > developers who made these changes) had discussed them publicly and > *waited* for my response before committing them. And bugzilla is a good tool to put patches so that we can discuss them. Vincent ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
