Yeah I didn't realize there was more to it. Fixing the segv is a given, the other might not be. The other part doesn't seem overly crazy, but good to contact the author regardless.
Hannes Janetzek wrote: > Am Sun, 06 Jan 2008 18:09:10 -0500 > schrieb Christopher Michael <[EMAIL PROTECTED]>: > > >> Enlightenment CVS wrote: >> >>> Enlightenment CVS committal >>> >>> Author : jeffdameth >>> Project : e_modules >>> Module : forecasts >>> >>> Dir : e_modules/forecasts >>> >>> >>> Modified Files: >>> e_mod_main.c >>> >>> >>> Log Message: >>> forcast fix: >>> - initialize inst->popup with NULL >>> - only update popup when necessary >>> >>> >> --Snip-- >> >> Did you check with the author of the module about these changes? CVS >> access is not a license to go willy-nilly on other people's code. >> >> dh >> >> > > Sorry, no I didnt. I mentioned the patch on irc and mekius said I > could commit this patch if it fixes a segv. but maybe he just meant > the initialize part. I will ask in future _always_ the author. > > regards, > Hannes > > > >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2005. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
