On Tue, 4 Dec 2007 01:41:39 +0200 "Gustavo Sverzut Barbieri" <[EMAIL PROTECTED]> babbled:
> On Dec 4, 2007 12:40 AM, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote: > > Vincent Torri [2007-12-03 23:04]: > > > > > > > > > On Mon, 3 Dec 2007, Gustavo Sverzut Barbieri wrote: > > > > > > > Hi guys, > > > > > > > > We found the root of those "unaligned loads", it was in canon.c > > > > (http://www.enlightenment.org/viewvc/e17/libs/epsilon/src/lib/exiftags/canon.c?hideattic=1&r1=1.2&r2=1.3), > > > > with a patch tilman applied in order to reduce relocations due lots of > > > > strings requiring it at load time. > > > > > > > > The problem, according to a Red Hat gcc compiler engineer friend of > > > > mine, is that that construction is not valid according to 6.7.2.1/18 > > > > of C99-TC2 and GCC should not allow that, so it's both a bug with GCC > > > > and canon.c. > > > > > > > > canon.c could be fixed and still do few relocations by using one huge > > > > string with \0 as separators and place pointers to segments of this > > > > string on the struct. But it's a pain to do. > > > > > > > > So, I'd like to ask those who are using this exiftags support from > > > > Epsilon. I really don't think this should be in epsilon anyway... the > > > > only use of it in CVS is at esmart_thumb... and it's about > > > > orientation, which is a standard tag... So I request permission to > > > > remove all this exiftags stuff, if required I can add the code to find > > > > out orientation support and generate already rotated images later. > > > > This should make things a lot simpler, smaller and faster to start. > > > > > > > > comments? may I remove? > > > > > > I have contacted tilman on irc. No answer from him yet, but if you can > > > wait some hours, or a day, so that he can answer > > > > I don't use exiftags. Simply ripping out the code and throwing it away > > doens't sound right though. > > I'm trying to find someone using it and which usage. To me it looks > more like old code lying around, if one wants to use exif, libexif > might be a wiser choice (upstream supported, etc). this could be an option as well. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
