On Jan 21, 2008 7:13 PM, Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> wrote: > On Jan 18, 2008 9:49 PM, The Rasterman Carsten Haitzler > <[EMAIL PROTECTED]> wrote: > > On Mon, 7 Jan 2008 18:46:17 +0100 "Cedric BAIL" <[EMAIL PROTECTED]> babbled: > > > > > > You will need to apply all patch if you want to use 16bpp engine or > > > SDL engine. Good review :) > > > > gustavo - 16bpp changes ok in principle (assuming the cache patch above goes > > in)? > > Ok, the patches are huge and boring to read. I checked some bits, but > not in much depth. > > Idea is fine, code looks good, so let it in.
Ah, my minor problems with this are: - structs can be better packed, "cspace" can get a smaller type and pack with "flags". - common_16: it should be made optional, no point in having this in most desktops or systems that will not use 16bpp engine. We can make it compile-time optional, but then evas will not be able to get 16bpp engine at a later point, so I'd still keep all the code in software_16 -- Gustavo Sverzut Barbieri -------------------------------------- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
