Almost :) The function _ecore_file_download_abort is still enclosed in the
HAVE_CURL ifdef.
The attached patch fixes the ramaining issue.
Regards
Lars Munch
On Tue, Mar 11, 2008 at 02:38:07PM +1100, Carsten Haitzler wrote:
> On Mon, 10 Mar 2008 17:28:55 +0100 [EMAIL PROTECTED] (Lars Munch) babbled:
>
> fixed :)
>
> > On Mon, Mar 10, 2008 at 03:43:04AM +1100, Carsten Haitzler wrote:
> > > On Fri, 7 Mar 2008 15:30:07 +0100 "Cedric BAIL" <[EMAIL PROTECTED]>
> > > babbled:
> > >
> > > > As I previously discussed, I did have some issue with evas_render not
> > > > being called when my computer receive data too fast. The problem was
> > > > the handling of the download prevented ecore to go into idle and call
> > > > evas_render.
> > > >
> > > > To fix this, this patch change the way the fd handler is used. When
> > > > some curl data are received, I stop all curl fd handler and setup an
> > > > idle handler. This force ecore to go in idle mode and call evas_render
> > > > before reading pending data.
> > > >
> > > > As ecore_file_download suffer the same problem and did want to
> > > > maintain two different user of curl library. I added a new interface
> > > > to ecore_con_url so that if it can directly write some data to any fd
> > > > and used this to reimplement ecore_file_download. This change should
> > > > not have a big impact on file download speed but the interface should
> > > > stay responsive what ever your computer and your download speed is !
> > >
> > > in cvs :)
> >
> > This patch seems to break linking againts libecore_file.so for me. I am
> > building ecore without curl support and after the latest changes in
> > ecore_file_download.c I get the following linking errors:
> >
> > arm-iwmmx-linux-gnueabi/usr/lib/libecore_file.so: undefined reference to
> > `_ecore_file_download_abort'
> >
> > To me it looks like the _ecore_file_download_abort function just needs
> > to be moved out of the HAVE_CURL ifdef's.
> >
> > Regards
> > Lars Munch
> >
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) [EMAIL PROTECTED]
>
Index: ./src/lib/ecore_file/ecore_file_download.c
===================================================================
RCS file: /var/cvs/e/e17/libs/ecore/src/lib/ecore_file/ecore_file_download.c,v
retrieving revision 1.20
diff -u -r1.20 ecore_file_download.c
--- ./src/lib/ecore_file/ecore_file_download.c 11 Mar 2008 03:38:22 -0000 1.20
+++ ./src/lib/ecore_file/ecore_file_download.c 11 Mar 2008 06:18:59 -0000
@@ -177,6 +177,17 @@
return 0;
}
+static void
+_ecore_file_download_abort(Ecore_File_Download_Job *job)
+{
+#ifdef HAVE_CURL
+ ecore_con_url_destroy(job->url_con);
+#endif
+ fclose(job->file);
+ free(job->dst);
+ free(job);
+}
+
#ifdef HAVE_CURL
static int
_ecore_file_download_url_compare_job(const void *data1, const void *data2)
@@ -230,17 +241,6 @@
return 0;
}
-static void
-_ecore_file_download_abort(Ecore_File_Download_Job *job)
-{
-#ifdef HAVE_CURL
- ecore_con_url_destroy(job->url_con);
-#endif
- fclose(job->file);
- free(job->dst);
- free(job);
-}
-
Ecore_File_Download_Job *
_ecore_file_download_curl(const char *url, const char *dst,
void (*completion_cb)(void *data, const char *file,
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
