Stefan Schmidt wrote:
> Hello.
> 
> On Fri, 2008-03-14 at 08:53, Sebastian Dransfeld wrote:
>> Stefan Schmidt wrote:
>>> Prototype code for parsing and printing out the recieved Dbus messages.
>> Please use the indentation style already used in e_dbus.
> 
> Sorry for breaking the given style here. I have seen you also changed
> the ident from one of my last patches from 3 to 2 spaces. Thanks for
> this.
> 
> Ironicly that one was took over from the older codebase. :)
> 
> So the preffered style for indentation is 2 spaces per block?

Yes. There are some projects who don't use the default efl style, got to 
live with it :)

> 
> Do you like me to update this patch or send a follow-up with my next
> batch?
> 
>> If you want to change the indentation, send a formatting patch.
> 
> OK. I was not sure how this is handled in this project. Some prefer
> doing format changes in the code you already are, some separate format
> patches. I can life with both and follow the project best practices.

We prefer formatting patches, as it often is hard to see where the real 
changes are if if formatting is intermixed.

Sebastian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to