On 05/31/2008 02:54, Chady Kassouf wrote: > I think the options parsing for Exhibit should be revamped. > > argv[1 + fullscreen + slideshow] is because you want to be able to call > exhibit with: > > $ exhibit -f -s /path/to/some/folder > > which is a hack and would probably be better fixed by correctly parsing the > parameters.
True on both counts... except the help it spits out says the order of
args is:
exhibit <url> <options>
in which case either the code does not work, or the help is borked.
>
>
>
> On Sat, May 31, 2008 at 7:47 AM, Ravenlock <[EMAIL PROTECTED]> wrote:
>
>> Hello,
>>
>> I wonder if the following isn't what was intended:
>>
>> Index: exhibit_main.c
>> ===================================================================
>> RCS file: /cvs/e/e17/apps/exhibit/src/bin/exhibit_main.c,v
>> retrieving revision 1.136
>> diff -u -r1.136 exhibit_main.c
>> --- exhibit_main.c 20 Feb 2008 08:52:15 -0000 1.136
>> +++ exhibit_main.c 31 May 2008 04:45:34 -0000
>> @@ -1241,7 +1241,7 @@
>> ecore_event_handler_add(EPSILON_EVENT_DONE, _ex_thumb_complete,
>> NULL));
>>
>> if(argc > 1 + fullscreen + slideshow)
>> - _ex_main_window_show(argv[1 + fullscreen + slideshow], fullscreen,
>> slideshow);
>> + _ex_main_window_show(argv[1], fullscreen, slideshow);
>> else
>> _ex_main_window_show(NULL, fullscreen, slideshow);
>>
>>
>> --
>> Regards,
>> Ravenlock
>>
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>>
>
>
--
Regards,
Ravenlock
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
