Cedric wrote:

>>     Something's not correct with the image-size-set function,
>> it should be taking the externally set pixel data, and copying
>> it to newly created data and setting that as the image data.
>>     Forget about the pixels-get function in that example, just
>> comment it out and instead add a call to the image-data-set func
>> instead... I've included a simplified version of their 'error-demo'
>> below which does this. It should work correctly but it doesn't.
>> :(
>>     
>
> Hum, if I add in evas_common_rgba_image_size_set (evas_image_data.c) a
> call to evas_common_blit_rectangle, it fix the problem. If you think
> it's the right solution I will commit the change.
>
> .....
> .....
>   

      Well, the semantics of the image-size-set function was decided
by Carsten, and his implementation was very comprehensive (eg. if there
was a file set but no data, it would first load the data, etc.).
      I can see both the original and yours as being reasonable... but
I'm not certain what a 'best' semantics should be, or what might be
most useful/efficient for common uses.

      Since the original semantics was given for quite a while now,
if one's going to change it then it might be a good idea to first
consult with Carsten and/or the list.
      What do you think the behavior ought to be, and why?


____________________________________________________________
Fabulous Spa Getaway!
Enter for your chance to WIN great beauty prizes everyday!
http://thirdpartyoffers.juno.com/TGL2141/fc/JKFkuJi7UrpjP5AySIwQ7UDdEUAb2cZsmVl1rqcBdXXZSM7q1z9rcj/

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to