On Mon, 7 Jul 2008, Timothy P. Horton wrote:
> I've uploaded a very preliminary version of my Summer of Code project, > the Evas_Quartz engine to Google Code, and opened it up for reviews. > Anyone interested, please come review my code! > > I'll warn anyone who's interested in reviewing that the code is rather > preliminary, there's lots of stuff missing, etc. > > Google Code project (for review): http://code.google.com/p/evas-quartz/ why didn't you add quartz support to the current glew engine ? It would have only been a matter of writing something similar to your gl_quartz/evas_quartz_main.c in gl_glew/ and minor modifications. That is, you would have had an engine almost without any work.... remark 1: i would rename the directory "quartz" to "software_quartz" if it does not use any specific acceleration, like other engines. remark 2: in quartz/engine.h, you defined a structure named _Evas_Quartz_Window but it is not obvious that it represents a window. In addition, in the definition of eng_window_new(), the parameters w and h are not used. Maybe you should remove them. anyway, nice work :) Vincent ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
