On Wed, Aug 20, 2008 at 9:01 PM, Joerg Sonnenberger
<[EMAIL PROTECTED]> wrote:
> On Wed, Aug 20, 2008 at 06:52:44PM +0200, Cedric BAIL wrote:
>> I am sorry, but this patch fail on make check on my computer. Both :
> Stupid fault, too many versions around. New patch attached.

Ok, just testing it and reviewing it. Could you tell me why you did
change this code, doesn't look like it's related to the other change.

@@ -881,13 +970,10 @@ eet_data_image_encode(const void *data,

    if (lossy == 0)
      {
-       if (compress > 0)
-         d = eet_data_image_lossless_compressed_convert(&size, data, w, h,
alpha, compress);
-
-       /* eet_data_image_lossless_compressed_convert will refuse to
compress something
-          if the result is bigger than the entry. */
-       if (compress <= 0 || d == NULL)
+       if (compress <= 0)
          d = eet_data_image_lossless_convert(&size, data, w, h, alpha);
+       else
+         d = eet_data_image_lossless_compressed_convert(&size, data, w, h,
alpha, compress);
      }
    else
      {


> Do you get timeouts from the test-suite as well?

We have currently to test that fail :
Eet Data Encoding/Decoding:eet_test_data_type_dump_undump
Eet File:eet_file_data_dump_test

due to a bug related to the handle of EET_G_UNKNOWN in
_eet_data_dump_encode. But other test should work just fine.

I did just run the tests with the new patch, and I am still
experiencing failure :

eet_suite.c:947:F:Eet Image:eet_image:0: Failure 'result == 0' occured
eet_suite.c:1161:F:Eet Image:eet_small_image:0: Failure 'data[0] != IM0' occured

So it fail on the first jpeg it try to write. I am sorry, I don't have
the time to dig more into this.

-- 
Cedric BAIL

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to