Hello Gustavo! thanks a lot for the tips. i'm not a very experienced c programmer, and also don't know a lot about X11 api or enlightement api.
About iconizing windows when they are focused, that it's useful for example when you are working on a task , and want to check another window just for a short moment. Then you click on the other window's icon and it becomes focused. Then you click again and the window gets iconized and you are back on your last window, that is the place you where working. Chances that you iconize accidentally you working window are very low. I'm now trying to understand why the configuration option is not saved. The final module features as task manager mode should be something like: Left click: if window hasn't focus or is iconized then raise and focus (implemented) if window has focus, then iconize (optionally people could be able to disable this) (half implemented) Left click and drag: if drags inside the IBox then it's just arranging order of icons. (not implemented) if drags inside the IBar then add the icon to the IBar launcher (if possible). (not implemented) Right click: Open menu with a) the actions and options for the window (not implemented) b) acces to shelf and IBox configuration (implemented) c) option to add the icon to the IBar (not implemented) Mouse Wheel: Rotate between windows of the same class (xterm, gimp, etc...) like engage did in the past. (not implemented) I think that with all that we gonna have a simple but powerful task manager Zaikxtox Gustavo Sverzut Barbieri wrote: > On Fri, Oct 10, 2008 at 8:52 AM, Ivan Hernandez <[EMAIL PROTECTED]> wrote: > >> This is a hacked version of IBox. It adds an option that changes the >> >> behavior so it has >> the functionality of the task managers commonly used on other environments >> like kde, gnome, xfce4, lxde, win32, etc. >> While ITaskNG is really interesting, it has some problems on my computer >> because i need to use compositing, and also IBox has the advantage of having >> the same look of IBar. >> >> Some things that needs to be implemented are: >> >> 1) Hidding dock windows (like trayer). >> 2) Providing a way to add running tasks icons to the IBar (like wmaker dock >> or the old engage module). >> > > those would rock, let's wait for them :-) > > comments about your code: > - fix whitespace issues, no trailing whitespaces, see wiki for hints > on how to configure emacs/vim to highlight them; > - read the diff before sending the code, you do some useless > changes that do not have to do with the subject of this change (ie: > changing some whitespace); > - send it as a patch next time: svn diff -x -up > trunk/e/e/src/modules/ibox > patch > - you don't keep the old behavior here: > > - if ((ev->button == 1) && (!ic->drag.dnd)) > - { > - e_border_uniconify(ic->border); > - e_border_focus_set(ic->border, 1, 1); > - } > + if (ev->button == 1) > + { > + if (ic->ibox->inst->ci->task_manager) > + { > + if (ic->border->iconic || !ic->border->focused) > + { > + e_border_uniconify(ic->border); > + e_border_raise(ic->border); > + e_border_focus_set(ic->border, 1, 1); > + } > + else > + { > + e_border_iconify(ic->border); > + } > + } else { > + e_border_uniconify(ic->border); > + e_border_focus_set(ic->border, 1, 1); > + } > + } > > a) you missed the " && (!ic->drag.dnd)", your out-most "else" > should read "else if (!ic->drag.dnd)" > b) "else" of "if (ic->border->iconic || !ic->border->focused)" is > weird, I don't want to iconify my window if I click the taskbar and > it's focused. but maybe it's just me :-) > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel