On Fri, Nov 21, 2008 at 1:20 PM, Cedric BAIL <[EMAIL PROTECTED]> wrote: > On Fri, Nov 21, 2008 at 3:50 PM, Iván Briano (Sachiel) > <[EMAIL PROTECTED]> wrote: >> Hello list, >> Attached is a patch that adds the Evas box functionality to Edje, >> allowing to define a box in themes, which can contain objects added >> by applications or other groups. It supports all the layouts defined >> in Evas by default and it can register custom layouts which the >> theme can also reference. > <snip> >> Test at will, opinions are of course welcome, specially for the layout >> register. > > Just reading your patch, not tested yet. I have only one comment using > hash for layout matching is not really a good option regarding memory > consuption. It would be better to put them in a rbtree, it will do > around 3 strcmp for all the current layout beeing fast enough without > using too much memory. At the same time, you could setup a static > array of Edje_Box_Layout with all default layout and initialize the > rbtree from it (would make the code cleaner imho). >
Truth be told, I just checked in Eina the names of functions for things I already knew. I will look at the other stuff and follow your suggestion. The static array is a good idea, I wanted to avoid the mess in init, but that one didn't occurred to me. > Anyway, it's really a good think seeing this stuff coming in edje. Table follows, stay tuned. > -- > Cedric BAIL > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
