On Mon, Dec 8, 2008 at 12:25 PM, Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> wrote: > On Mon, Dec 8, 2008 at 8:57 AM, Cedric BAIL <[EMAIL PROTECTED]> wrote: >> On Mon, Dec 8, 2008 at 11:40 AM, Gustavo Sverzut Barbieri >> <[EMAIL PROTECTED]> wrote: >>> On Mon, Dec 8, 2008 at 8:18 AM, Enlightenment SVN >>> <[EMAIL PROTECTED]> wrote: >>>> Log: >>>> Application and library using Eina Magic API should be able to decide if >>>> they >>>> want to check magic or not. This should not be forced by Eina config. >>>> >>>> Author: cedric >>>> Date: 2008-12-08 02:18:05 -0800 (Mon, 08 Dec 2008) >>>> New Revision: 38014 >>>> >>>> Modified: >>>> trunk/eina/src/include/eina_magic.h >>>> >>>> Modified: trunk/eina/src/include/eina_magic.h >>> >>> then we must fix all users of structures to include it, that includes >>> all eina_inline_*.x, every eina_*.c that uses headers with EINA_MAGIC; >>> and like, really this is asking for problems. >> >> Well we should put eina_config.h in each header using directly >> EINA_MAGIC (only accessor and iterator are lacking it right now) and >> all eina_*.c using EINA_MAGIC should include eina_private.h so this >> should be safe for eina. And I don't think you can include >> eina_inline_*.x without their related eina_*.h. >> >> So yes, manipulating MAGIC is a little bit tricky, but we need that or >> we will not be able to move ECORE_MAGIC to EINA_MAGIC. > > Yes, I caught the first problem with 2 files inside eina that were > misbehaving, I don't recall which, but it was about array setting the > magic number in the wrong place because of missing eina_config > (possible it was on the eina_inline_array.x) side.
Could you check please. Because eina_array.h already include eina_config.h, so it should not be a source of problem. -- Cedric BAIL ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
