On Mon, Dec 29, 2008 at 2:02 PM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > On Mon, Dec 29, 2008 at 10:41 AM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: >> Log: >> Don't generate warning in some little case. > > I strongly disagree with this patch. Eina Hash is not like Evas Hash, > by hiding this "warnings in some little case" we're hiding bugs. It's > better to fix those bugs and not hide these warnings.
> We add these safety checks to avoid our libraries crashing badly on > users, not because API should really support these NULL pointers, > they're invalid values. It's like strlen(NULL), it does not make > sense. That's the typical case I want to avoid adding extra if around place where returning 0 would have make sense. I didn't remove all check only on find and population, typically used by cache system. -- Cedric BAIL ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
