On Thu, Feb 19, 2009 at 3:09 PM, Lars Munch <[email protected]> wrote:
> This patch adds gstreamer v4l support to emotion. If you got a webcam it can
> be tested by doing:
>
> emotion_test -gstreamer v4l://
>
> This will use the first video device /dev/video0.
>
> If you do not have a webcam, you can also try it using the Virtual Video
> driver
> (modprobe vivi). If you got more that one video device you can also use
>
> emotion_test -gstreamer v4l://0 v4l://1
>
> to play from both /dev/video0 and /dev/video1.
Lars, sorry taking so review it, but here it is:
> @@ -605,8 +616,6 @@ em_len_get(void *video)
> return val / 1000000000.0;
>
> fallback:
> - fputs("Gstreamer reported no length, try existing sinks...\n", stderr);
> -
Try to not modify parts not relevant to your patch.
> @@ -93,7 +93,7 @@ file_new_decoded_pad_cb(GstElement *decodebin,
> GstElement *queue;
> GstPad *videopad;
>
> - vsink = (Emotion_Video_Sink *)malloc(sizeof(Emotion_Video_Sink));
> + vsink = (Emotion_Video_Sink *)calloc(1, sizeof(Emotion_Video_Sink));
same here, I guess malloc->calloc is not required by your patch, is
it? There are others like it in this patch, I'll not comment on them
again.
> + int devno = 0;
...
> + sscanf(device, "v4l://%d", &devno);
I'd say to check sscanf() result and just set devno =0 on errors:
if (sscanf(device, "v4l://%d", &devno) != 1)
devno = 0;
so very minor stuff, send a new patch and I'll commit.
Regards,
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
