On Tue, Mar 24, 2009 at 4:36 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
>  Use an enum for the backend
>
> Author:       caro
> Date:         2009-03-24 00:36:46 -0700 (Tue, 24 Mar 2009)
> New Revision: 39664
>
> Modified:
>  trunk/evas/src/modules/engines/software_x11/Evas_Engine_Software_X11.h
>
> Modified: 
> trunk/evas/src/modules/engines/software_x11/Evas_Engine_Software_X11.h
> ===================================================================
> --- trunk/evas/src/modules/engines/software_x11/Evas_Engine_Software_X11.h    
>   2009-03-24 07:10:46 UTC (rev 39663)
> +++ trunk/evas/src/modules/engines/software_x11/Evas_Engine_Software_X11.h    
>   2009-03-24 07:36:46 UTC (rev 39664)
> @@ -3,11 +3,15 @@
>
>  #include <X11/Xlib.h>
>
> +typedef enum
> +{
> +  EVAS_ENGINE_INFO_SOFTWARE_X11_BACKEND_XLIB,
> +  EVAS_ENGINE_INFO_SOFTWARE_X11_BACKEND_XCB
> +} Evas_Engine_Info_Software_X11_Backend;
> +
>  typedef struct _Evas_Engine_Info_Software_X11 Evas_Engine_Info_Software_X11;
>
>  /*
> - * backend: 0 == Xlib, 1 == XCB
> - *
>  *               Xlib       |      XCB
>  * connection | Display *   |  xcb_connection_t *
>  * screen     | NULL        |  xcb_screen_t *
> @@ -25,23 +29,23 @@
>
>    /* engine specific data & parameters it needs to set up */
>    struct {
> -      int          backend;
> -      void        *connection;
> -      void        *screen;
> -      unsigned int drawable;
> -      unsigned int mask;
> -      void        *visual;
> -      unsigned int colormap;
> -      int          depth;
> -      int          rotation;
> +      Evas_Engine_Info_Software_X11_Backend backend;
> +      void                                 *connection;
> +      void                                 *screen;
> +      unsigned int                          drawable;
> +      unsigned int                          mask;
> +      void                                 *visual;
> +      unsigned int                          colormap;
> +      int                                   depth;
> +      int                                   rotation;
>
> -      int          alloc_grayscale    : 1;
> -      int          debug              : 1;
> -      int          shape_dither       : 1;
> -      int          destination_alpha  : 1;
> -      int          track_mask_changes : 1;
> +      int                                   alloc_grayscale    : 1;
> +      int                                   debug              : 1;
> +      int                                   shape_dither       : 1;
> +      int                                   destination_alpha  : 1;
> +      int                                   track_mask_changes : 1;

ouch, please fix those bitfields to be unsigned or it will be just the
sign and will hold only 0 and -1, not 0 and 1.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to