On Sun, 5 Apr 2009 02:35:21 +0200 Brian 'morlenxus' Miculcy <[email protected]>
said:

> Wouldn't it be better if these keybindings are configurable within the e
> keybindings manager? We end in having keybindings in e modules and no one can
> change them without hacking the code. But a lot of people like e because of
> the keybinding power it has...

there's a difference to a keybinding (global) that steals a key from everywhere
- nothing else but e can use it, and simply responding to key events on that
window when focused. very different.

yes it would be nice - but there is no mechanism in place for this and the
normal keybindings stuff isn't really the place for this as these keys are
grabbed. so this is just fine for now.

> Greets,
> Brian 'morlenxus' Miculcy
> 
> On Sat, Apr 04, 2009 at 05:26:31PM -0700, Enlightenment SVN wrote:
> > Log:
> >   
> >    * E_Fwin:
> >   
> >   Ctrl+w -> close the window
> >   Ctrl+a -> select all
> >   
> >   
> > Author:       davemds
> > Date:         2009-04-04 17:26:31 -0700 (Sat, 04 Apr 2009)
> > New Revision: 39865
> > 
> > Modified:
> >   trunk/e/src/bin/e_fm.c trunk/e/src/bin/e_fm.h
> > trunk/e/src/modules/fileman/e_fwin.c 
> > 
> > Modified: trunk/e/src/bin/e_fm.c
> > ===================================================================
> > --- trunk/e/src/bin/e_fm.c  2009-04-04 23:28:37 UTC (rev 39864)
> > +++ trunk/e/src/bin/e_fm.c  2009-04-05 00:26:31 UTC (rev 39865)
> > @@ -252,6 +252,7 @@
> >  
> >  static void _e_fm2_icon_sel_first(Evas_Object *obj);
> >  static void _e_fm2_icon_sel_last(Evas_Object *obj);
> > +static void _e_fm2_icon_sel_any(Evas_Object *obj);
> >  static void _e_fm2_icon_sel_prev(Evas_Object *obj);
> >  static void _e_fm2_icon_sel_next(Evas_Object *obj);
> >  static void _e_fm2_icon_sel_down(Evas_Object *obj);
> > @@ -980,6 +981,18 @@
> >  }
> >  
> >  EAPI void
> > +e_fm2_all_sel(Evas_Object *obj)
> > +{
> > +   E_Fm2_Smart_Data *sd;
> > +   
> > +   sd = evas_object_smart_data_get(obj);
> > +   if (!sd) return; // safety
> > +   if (!evas_object_type_get(obj)) return; // safety
> > +   if (strcmp(evas_object_type_get(obj), "e_fm")) return; // safety
> > +   _e_fm2_icon_sel_any(obj);
> > +}
> > +
> > +EAPI void
> >  e_fm2_custom_theme_set(Evas_Object *obj, const char *path)
> >  {
> >     E_Fm2_Smart_Data *sd;
> > @@ -4964,6 +4977,20 @@
> >     _e_fm2_icon_make_visible(ic);
> >  }
> >  
> > +static void
> > +_e_fm2_icon_sel_any(Evas_Object *obj)
> > +{
> > +   E_Fm2_Smart_Data *sd;
> > +   E_Fm2_Icon *ic;
> > +   Eina_List *l;
> > +   
> > +   sd = evas_object_smart_data_get(obj);
> > +   if (!sd) return;
> > +   if (!sd->icons) return;
> > +   EINA_LIST_FOREACH(sd->icons, l, ic)
> > +     if (!ic->selected) _e_fm2_icon_select(ic);
> > +}
> > +
> >  static E_Fm2_Icon *
> >  _e_fm2_icon_next_find(Evas_Object *obj, int next, int match_func
> > (E_Fm2_Icon *ic, void *data), void *data) {
> > 
> > Modified: trunk/e/src/bin/e_fm.h
> > ===================================================================
> > --- trunk/e/src/bin/e_fm.h  2009-04-04 23:28:37 UTC (rev 39864)
> > +++ trunk/e/src/bin/e_fm.h  2009-04-05 00:26:31 UTC (rev 39865)
> > @@ -138,6 +138,7 @@
> >  EAPI void                  e_fm2_underlay_show(Evas_Object *obj);
> >  EAPI void                  e_fm2_underlay_hide(Evas_Object *obj);
> >  EAPI void                  e_fm2_all_unsel(Evas_Object *obj);
> > +EAPI void                  e_fm2_all_sel(Evas_Object *obj);
> >  EAPI void                  e_fm2_path_get(Evas_Object *obj, const char
> > **dev, const char **path); EAPI void                  e_fm2_refresh
> > (Evas_Object *obj); EAPI const char           *e_fm2_real_path_get
> > (Evas_Object *obj);
> > 
> > Modified: trunk/e/src/modules/fileman/e_fwin.c
> > ===================================================================
> > --- trunk/e/src/modules/fileman/e_fwin.c    2009-04-04 23:28:37 UTC
> > (rev 39864) +++ trunk/e/src/modules/fileman/e_fwin.c        2009-04-05
> > 00:26:31 UTC (rev 39865) @@ -935,6 +935,16 @@
> >          e_fwin_new(con, dev, path);
> >          return;
> >       }
> > +   if (!strcmp(ev->key, "w"))
> > +     {
> > +        e_object_del(E_OBJECT(fwin));
> > +        return;
> > +     }
> > +   if (!strcmp(ev->key, "a"))
> > +     {
> > +        e_fm2_all_sel(fwin->fm_obj);
> > +        return;
> > +     }
> >       }
> >  }
> >  
> > 
> > 
> > ------------------------------------------------------------------------------
> > _______________________________________________
> > enlightenment-svn mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]


------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to