On Mon, May 4, 2009 at 3:51 PM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > On Mon, May 4, 2009 at 3:23 PM, Bruno Dilly <bdi...@profusion.mobi> wrote: >> This patch fix some bugs in gstreamer module. > > not good on this chunk: > > @@ -101,6 +101,7 @@ > GstCaps *sink_caps; > > asink = (Emotion_Audio_Sink *)eina_list_data_get(alist); > + alist = eina_list_next(alist); > sink_pad = > gst_element_get_pad(gst_bin_get_by_name(GST_BIN(ev->pipeline), > "a52dec"), "src"); > sink_caps = gst_pad_get_caps(sink_pad); > > original alist is lost. :-(
Yeah, reading just the patch, it looks like alist is lost, but ev keeps this pointer (ev->audio_sinks). I don't know why, but when the eina_list changes were applied (commit 39195), ecore_list_next was substituted only by eina_list_data_get.. So, taking a look in the entire function, it looks right. I will try to describe better the next patches. > > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
