I agree. But maybe we can have more thoughts on this. Anyone?
On Sat, Jun 6, 2009 at 12:48 PM, Albin Tonnerre <albin.tonne...@gmail.com>wrote: > On Sat, Jun 06, 2009 at 12:12:49PM -0300, Andre Dieb wrote : > > This patch contains my other two previous patches: > > > > - [PATCH] Fix eina mempool leak, init error handling, remove consumed > > TODO msg > > - [PATCH] Add checks to eina_module_new > > > > Also fixes the build error with --disable-magic-debug. > > I still think that when ecore_magic is disabled, it would be better to use > functions rather than preprocessor macros for things like > eina_magic_string_init(). Indeed, that would avoid exporting different > symbols > depending on whether eina has magic-debug enabled or not. If you use > macros, an > application using magic debug compiled against eina without magic-debug > will > have to be recompiled to benefit from it if it gets enabled in eina at a > later > point. If you use functions, this is no longer an issue. > > Thoughts ? > > Regards, > -- > Albin Tonnerre > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iQIcBAEBCAAGBQJKKo/ZAAoJEBEG8gBbtuSlg2EQAJuv4Q3oxSywbadvWWjNTpRA > iAOhtbABiWcRTnRbuK54RsGBrl+Z+BIjXJSStchY8Et2FFJzpZcd9HrWewHSbf3m > XcTC9usC9J3k8jTBzlsP1nvSz2br50yJDmzdu2uZA16XcySQGYBJxseiju6MhKsp > Kc6qfUSKCcml3Ovh0G2RjSjmWCPDodVvMNeu/2hofi03rtWdMnMXw6EtSB2VDkkb > GndGz9S2yxKDu6bbn/JnelqQ2N7gSw0d6wlAkKr1hlQFZ4RMACQFWhBlL2k7YSIU > JaUPBevrZ5KwWyQlnKcy2d7WTUNgUVTfY2c445wEMmEUQUEftPUNlAWHgTyVtWZ+ > bIv3A3qb/Ypk0qdrZ6ipIlFEHI+t6zow8VRtepBslEFIHqHXvBNFOQbXwbI5qzyr > 9KmTn7gfMpMDc6jUf9NMlx6Z1tsabaQzheKn7Ni3CWM5bDQtO2s+QDSBdy138lv2 > 8opXVWi7N3WVyK3yrLJ8zirFobsZPaKrAU7si8NEupm1haMXFSqWqjZLFxsdrVEK > bcNXYKtMKgfQtMrq4u9LYVAAWK3v7jhgBU/hrVwELCGC16dulhcRaspgfaedi7sU > 19qOUhvWB02TiqYM04hz+AxM3TKnx8CORSuMoQTA1LfyNR2z+DM3+J56aPK7R+kt > EARZRhLTlje9ue7PpU1R > =p47M > -----END PGP SIGNATURE----- > > -- André Dieb Martins Embedded Systems and Pervasive Computing Lab (Embedded) Electrical Engineering Department (DEE) Center of Electrical Engineering and Informatics (CEEI) Federal University of Campina Grande (UFCG) Blog: http://genuinepulse.blogspot.com/ ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
