On Mon, Jun 8, 2009 at 10:44 AM, Enlightenment
SVN<[email protected]> wrote:
>    if (update_timer)
> -     {
> -       ecore_timer_del(update_timer);
> -       update_timer = NULL;
> -     }
> -
> +     ecore_timer_del(update_timer);
> +

why is that? You just introduced a segfault or mis-behavior in the
code. If you do not make the pointer NULL, then next code that checks
for update_timer before adding new timer will not work anymore and
worse: next execution will call ecore_timer_del() on the same freed
pointer = SEGV.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to