2009/6/1 Gustavo Sverzut Barbieri <[email protected]>:
> 2009/5/29 André Loureiro <[email protected]>:
>> Hi guys,
>>
>> I've made the bindings for epdf library, and I would like put it
>> in your svn repository, how can i do this?
>> the current repository is in gitorious.org, but I think that is not
>> better place.
>
> Hi André,
>
> Before I merge your work inside SVN I need you to fix some problems with it:
> - release the GIL in functions that (possibly) take long, like
> render(). See
> http://svn.enlightenment.org/svn/e/trunk/BINDINGS/python/python-ecore/ecore/ecore.c_ecore.pyx
> (Reminds me that I need to add such to evas render as well, if you
> could submit a patch to improve that it would be great!)
> - do not use self.Xobj, use self.obj instead, so it's consistent
> among all efl. (for C object pointer)
> - consistent name of classes: epdf.Page, not epdf.EPage.
> - avoid creating dicts for things that do not need one, for example
> in EPage.text_find(), either return a tuple, or return an evas.Rect
> instead.
> - watch out memory leaks! EPage.text_find() is leaking the returned
> list and nodes, you need to free it. Please review the whole code in
> parts that returns lists and char*.
> - watch out NULL -> python. If any function can return NULL on
> char*, you need to check for that and convert to None yourself,
> otherwise the application will segv.
>
> Regards,
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: [email protected]
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
Gustavo,
Sorry for delay, my ubuntu was broken and I have to fix that before
send somethig to e-devel.
So, I've made your suggestions and I added 2 classes, Index and IndexItem
Index you can get the indexes from document, doc.index.get_items(), get_items
return a list of IndexItem. I fix the text_find, and the name classes
are consistent
Document, Page, Index and IndexItem.
I'm release the GIL in page.render() and page.render_slice().
All the functions that return char * or NULL now returns the correct
value to python.
The leaks in text_find and text_get are fixed, the pointers to
eina_list are deallocate with
eina_list_free.
At least the binding is attached.
Regards.
--
--
André L. V. Loureiro
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
