Hello
I found a bug in calculating config dialog position.
Steps to reproduce:
click on Setting -> Wallpaper, then click several times Advanced/Basic. You'll see that windows is moving up :)
Attached patch correct this.

ps. me and Gustavo tryed to fix it differently - just by centering the window. But i realized - that we can't do that - because if a user moves dialog window anywhere else - the dialog then shows up on center (after click Advanced/Basic) - which is of course wrong behavior...
So this is my first version of a patch.

regards
--
manio
jabber/e-mail: ma...@skyboo.net
http://manio.skyboo.net

Index: e/src/bin/e_config_dialog.c
===================================================================
--- e_config_dialog.c	(revision 40987)
+++ e_config_dialog.c	(working copy)
@@ -271,8 +271,8 @@
 
 	e_dialog_show(cfd->dia);
 	if (cfd->icon) e_dialog_border_icon_set(cfd->dia, cfd->icon);
-	x = pdia->win->border->x + ((pdia->win->w - cfd->dia->win->w) / 2);
-	y = pdia->win->border->y + ((pdia->win->h - cfd->dia->win->h) / 2);
+	x = pdia->win->x + ((pdia->win->w - cfd->dia->win->w) / 2);
+	y = pdia->win->y + ((pdia->win->h - cfd->dia->win->h) / 2);
 	if (x < 0) x = 0;
 	if (y < 0) y = 0;
 	if ((x + cfd->dia->win->w) > (pdia->win->container->w))
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to