Carsten Haitzler (The Rasterman) schrieb: > On Sat, 06 Jun 2009 19:42:52 +0200 Peter Wehrfritz <[email protected]> > said: > > >> Cedric BAIL schrieb: >> >>> On Sat, Jun 6, 2009 at 5:48 PM, Albin Tonnerre<[email protected]> >>> wrote: >>> >>>> On Sat, Jun 06, 2009 at 12:12:49PM -0300, Andre Dieb wrote : >>>> >>>> >>>>> This patch contains my other two previous patches: >>>>> >>>>> - [PATCH] Fix eina mempool leak, init error handling, remove consumed >>>>> TODO msg >>>>> - [PATCH] Add checks to eina_module_new >>>>> >>>>> Also fixes the build error with --disable-magic-debug. >>>>> >>>>> >>>> I still think that when ecore_magic is disabled, it would be better to use >>>> functions rather than preprocessor macros for things like >>>> eina_magic_string_init(). Indeed, that would avoid exporting different >>>> symbols depending on whether eina has magic-debug enabled or not. If you >>>> use macros, an application using magic debug compiled against eina without >>>> magic-debug will have to be recompiled to benefit from it if it gets >>>> enabled in eina at a later point. If you use functions, this is no longer >>>> an issue. >>>> >>>> Thoughts ? >>>> >>>> >>> I strongly disagree, when you disable magic debug in eina, you want to >>> avoid it's cost at all. This include the call of the function call. >>> And from my test, it does have a big impact to just enter an empty >>> function. When we are speaking about performance, I think we can >>> accept the little tradeoff of needing to recompile application using >>> eina for maximum performance. >>> >>> >> Are you kidding? How often do you call this function? Maybe 20 times, >> even if you call it 100 or 1000 times, I strongly doubt that you can >> measure a performance difference. >> > > eina_list_append will be called often 1000's of tims in a tight loop and > 100,000's of times over the period of minutes. it's used in sorting files. a > dir with 5000 would take a good 20-30% longer to build f they were functions. >
Yes, but eina_list_append() does not call eina_magic_string_init(). For the list it is only called once in eina_list_init(). ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
