On Sun, Aug 16, 2009 at 8:54 PM, Andre Dieb<andre.mart...@ee.ufcg.edu.br> wrote: > Another attempt attached, see modifications list and inline comments below. > > - DOM is now a prefix: EINA_LOG_DOM_(level) > - renamed EINA_COLOR_NOTHING to EINA_COLOR_RESET > - fixed loop problem at pending domains parse > - removed eina_log_msg_* funcs, they're kept on eina_error > - removed trailing whitespaces > - changed colors > - domain free happens now on unregister() > - shutdown ignores deleted entries > - added a test case for level color normalization (if negative, show it with > the lowest color possible - crit. If higher than debug, show it with light > blue)
will look. > I couldn't avoid ##__VA_ARGS__ on macros, help would be good. > > On Sun, Aug 16, 2009 at 11:50 AM, Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> wrote: >> >> On Sun, Aug 16, 2009 at 5:45 AM, Andre Dieb<andre.mart...@ee.ufcg.edu.br> >> wrote: >> > One more thing, >> > >> > On Sun, Aug 16, 2009 at 5:26 AM, Andre Dieb >> > <andre.mart...@ee.ufcg.edu.br> >> > wrote: >> >> >> >> Sorry for the HTML! :) >> >> >> >> On Sat, Aug 15, 2009 at 10:39 PM, Gustavo Sverzut Barbieri >> >> <barbi...@profusion.mobi> wrote: >> >>> >> >>> On Sat, Aug 15, 2009 at 5:55 PM, Andre >> >>> Dieb<andre.mart...@ee.ufcg.edu.br> >> >>> wrote: >> >>> > Changes: >> >>> > >> >>> > Module name is now eina_log (but I didn't delete eina_error yet, as >> >>> > we >> >>> > should delete it only when the transition is completed) >> >>> > Docs on header and basic doc on .c file, but there's a lot of room >> >>> > for >> >>> > doc >> >>> > improvement >> >>> > Save name on domains >> >>> > Clean realloc code >> >>> > Keep parsing EINA_LOG_LEVELS even when user types wrong (e.g. >> >>> > domain1:level1,domain2:,domain3,domain:5) >> >>> > Migrate old global logger code to global logger (i.e. remove old >> >>> > deprecated >> >>> > functions) >> >>> >> >>> arghhhhhh... HTML MAIL! >> >>> >> >>> now to the points >> >>> - _DOM is not a suffix, rather a prefix namespace... like >> >>> EINA_LOG_ERR and EINA_LOG_DOM_ERR... >> >>> - I remember Sun compiler barfing at ##__VA_ARGS__, maybe we need to >> >>> avoid that? Vincent?? (avoid that is define just as (...) and user is >> >>> obligated to give at least one parameter, fmt. That makes things >> >>> uglier IMHO) >> >> >> >> That == define as "..." ? Should it be done with ... ? >> >> I'm sorry, I didn't follow. >> >> ## is a "hack" to remove the last "," if no arguments are provided. >> So these would work similarly >> >> X(a, ...) bla(a, ##__VA_ARGS__) >> X(...) bla(__VA_ARGS__) >> >> tests >> >> X(1, 2, 4) bla(1, 2, 4) >> X(1) bla(1) > > Here's how it is now. Could you please point how to avoid ## ? > > #define EINA_LOG(DOM, LEVEL, fmt, ...) \ > eina_log_print(DOM, LEVEL, __FILE__, __FUNCTION__, __LINE__, fmt, > ##__VA_ARGS__) > > #define EINA_LOG_DOM_CRIT(DOM, fmt, ...) \ > EINA_LOG(DOM, EINA_LOG_LEVEL_CRITICAL, fmt, ##__VA_ARGS__) EINA_LOG_DOM_CRIT(DOM, ...) \ EINA_LOG(DOM, EINA_LOG_LEVEL_CRITICAL, __VA_ARGS__) but I said already, it's uglier =/ -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
