Hello guys

> 1. Adding or deleting  modules to a shelf often makes one of the other 
> modules appear in duplicate. Apparently the shelf setting does not store 
> the module as a duplicate in the config file since

I have this trouble too as well. I discovered next problem in
e_gadcon_unpopulate():

EINA_LIST_FREE(gc->clients, gcc)
  {
      ...
      e_object_del(E_OBJECT(gcc));
  }


e_object_del() affects list in that way so after this call
gc->clients->data pointer is changed. Exactly first list item is skipped
after call. That leads to removal only each second item instead of
wiping out whole the list. That is because not deleted gadgets reamins
and duplicated. Perhaps there are some bad memory management or
whatever. I including here temporary workaround pacth intendedd not for
upstream commiting purposes but as provisional solution to show the
problem. Hope it helps although the problem itself seems too deep for
me.

Regards, Victor.

This is workaround for duplicate gadgets appearing before removing a gadget from a shelf.

 e_gadcon.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Index: e17-svn/src/bin/e_gadcon.c
===================================================================
--- e17-svn/src/bin/e_gadcon.c	(revision 41941)
+++ e17-svn/src/bin/e_gadcon.c	(working copy)
@@ -458,8 +461,13 @@
 
    E_OBJECT_CHECK(gc);
    E_OBJECT_TYPE_CHECK(gc, E_GADCON_TYPE);
-   EINA_LIST_FREE(gc->clients, gcc)
+//   EINA_LIST_FREE(gc->clients, gcc)
+//* FIXME :temporary workaround here
+   while(gc->clients)
      {
+        gcc = eina_list_data_get(gc->clients);
+        gc->clients = eina_list_remove_list(gc->clients, gc->clients);
+// */
 	if (gcc->menu) 
 	  {
 	     e_menu_post_deactivate_callback_set(gcc->menu, NULL, NULL);
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to