On Sat, 2009-08-29 at 18:56 -0500, Nick Hughart wrote: > So the edge bindings have once again ticked me off. So much so that > I've made the attached patch to correct it's flaws. I tried to keep > as much of the mechanisms the same even though I don't exactly like how > it's done right now. > > Anyway, the patch fixes a couple of things. > > First it will hide any of the edge windows if that edge is not being > used. It is pointless to have the entire 1px border of the screen > unusable when I have no edge bindings.
You need to do a bit more than just monitor the bindings. The shelves also use the edge events to show/hide themselves. With your patch, if a shelf is set to auto-hide, it will never show if that edge does not have a binding as well. I am personally against this bit of patch (and I was against it before), as the edges provide more than just bindings. They also provide events that can (and are) used regardless of whether a binding for that edge exists or not. I guess one solution would be for all users of these events to instead provide actions, which can be user-bound to a specific edge, but I am not sure how well that would work, since it would require user action, which might not be desirable. The later bit of the patch also fixes your gripe a bit, since that 1px of screen realestate becomes usable for certain apps (imho all that really need the edges are fullscreen games anyway). > > Second it fixes the behavior of the fullscreen option. Previously the > edges were set above all windows, even fullscreen. The only difference > with the option set was that events would be ignored, but the edge > window was still in the way stealing events. It is much better to > actually layer things properly so that when a fullscreen app is active, > the edge windows are layered below it and thus do not get in the way at > all and don't even have to ignore the events because they never happen. The layers look good. Though I wonder whether setting layers to be LAYER - 1 would be better. So for instance, when the fullscreen option is not turned on, the edge windows would be 1 layer below the fullscreen windows. Not sure how window stacking works, so maybe your solution works just as well. > > Patch attached. I would just commit it, but I know I was met with > resistance for some reason the last time I brought these issues up. > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ enlightenment-devel mailing > list enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
