On Thu, 3 Sep 2009 18:54:40 -0300 Iván Briano (Sachiel) <[email protected]> said:
> On Thu, Sep 3, 2009 at 6:25 PM, Carsten Haitzler<[email protected]> wrote: > > On Thu, 3 Sep 2009 10:07:54 -0300 Iván Briano (Sachiel) <[email protected]> > > said: > > > >> On Wed, Sep 2, 2009 at 9:43 PM, Carsten Haitzler<[email protected]> > >> wrote: > >> > On Sun, 30 Aug 2009 07:40:47 +0200 (CEST) Vincent Torri > >> > <[email protected]> said: > >> > > >> > hmm i disagree with some of the doc. specifically > >> > > >> > blah > >> > { > >> > xx; > >> > } > >> > > >> > i have always had/used: > >> > blah > >> > { > >> > xx; > >> > } > >> > > >> > ie {}'s are indented a bit. > >> > > >> > but... we can argue over little things all day long. imho the ONLY way > >> > this will work is if we have an indent line/rule that works. and the > >> > only way this will work is if we require code is "indented" before a > >> > commit. in fact i'd even consider this should be done as part of the > >> > commit p;rocess automatically. all *.c *.h files should be > >> > > >> > 1. patched with commmit > >> > 2. run through indent > >> > 3. actual patch/commit generated and put into svn. > >> > > >> > can svn do this - ie add a stage in the commit pipeline? that's the q. > >> > otherwise its a policy and people need to remember to run indent on their > >> > edited files (or new added files). > >> > > >> > >> Should be doable with a pre-commit hook. > > > > pre-commit is allowed to modify the content of the incoming code of that > > commit before merge to the code in the tree? if so - good. then that should > > be used. once we agree on the indent arguments. > > > > Apparently, it can but it's not a good idea. It can cause problems with local > cache kept by svn, so the usual advice is to reject commits and not modify > them. what kind of problems? as such all svn needs to do is 1. get "current file" from svn 2. get "new file" from client (not a diff) 3. run indent on "new file" from client 4. generate diff from these 2 files now 5. record and apply diff to "current file" the svn data shouldnt care as svn's copies of it (and thus caches) are using a modified commit to modify the svn files in the normal way (normally logically step 3 doesnt exist. we added it). > >> >> Hey, > >> >> > >> >> I think that we all agree that the current mix of whitespace and > >> >> tabulation in most of the source code is not that very nice. > >> >> Also, the libraries are often using the coding style of the original > >> >> author, hence we have several different coding style in different > >> >> libraries (eina being even worse, as it uses both raster and Jorge > >> >> coding style...) > >> >> > >> >> As we plan to release the EFL, maybe it would be good to choose a common > >> >> coding style and to modify the source code accordingly (preferably > >> >> before the release, but that can be done after as it would be a lot of > >> >> work). > >> >> > >> >> I have attached a proposal. The structure is based on the cairo coding > >> >> style file (I have copy/pasted most of the sentences as I'm not an > >> >> english speaker/writer, but I modified the examples of course...). > >> >> > >> >> Feel free to give your ideas, remarks, modifications, additions, etc... > >> >> We are not in a hurry, so discussion is welcome, of course. > >> >> > >> >> Once we all agree on a coding style, i think that such file should be > >> >> included in all EFL svn repo and future tarballs. > >> >> > >> >> regards > >> >> > >> >> Vincent > >> > > >> > > >> > -- > >> > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > >> > The Rasterman (Carsten Haitzler) [email protected] > >> > > >> > > >> > ------------------------------------------------------------------------------ > >> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > >> > 30-Day trial. Simplify your report design, integration and deployment - > >> > and focus on what you do best, core application coding. Discover what's > >> > new with Crystal Reports now. http://p.sf.net/sfu/bobj-july > >> > _______________________________________________ > >> > enlightenment-devel mailing list > >> > [email protected] > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > >> > >> ------------------------------------------------------------------------------ > >> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > >> trial. Simplify your report design, integration and deployment - and focus > >> on what you do best, core application coding. Discover what's new with > >> Crystal Reports now. http://p.sf.net/sfu/bobj-july > >> _______________________________________________ > >> enlightenment-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
