On Mon, Sep 7, 2009 at 6:31 PM, [email protected]<[email protected]> wrote: >>> fix systray to work with argb shelf windows >>> >>> Author: jeffdameth >>> Date: 2009-09-07 09:41:22 -0700 (Mon, 07 Sep 2009) >>> New Revision: 42329 >>> >>> Modified: >>> trunk/e/src/modules/systray/e_mod_main.c >>> >>> Modified: trunk/e/src/modules/systray/e_mod_main.c >>> =================================================================== >>> --- trunk/e/src/modules/systray/e_mod_main.c 2009-09-07 16:32:26 UTC >>> (rev 42328) >>> +++ trunk/e/src/modules/systray/e_mod_main.c 2009-09-07 16:41:22 UTC >>> (rev 42329) >>> @@ -480,7 +480,8 @@ >>> evas_object_geometry_get(o, &x, &y, &w, &h); >>> if (w < 1) w = 1; >>> if (h < 1) h = 1; >>> - inst->win.base = ecore_x_window_new(inst->win.parent, x, y, w, h); >>> + inst->win.base = ecore_x_window_new(0, 0, 0, w, h); >>> + ecore_x_window_reparent(inst->win.base, inst->win.parent, x, y); >>> ecore_x_window_background_color_set(inst->win.base, r, g, b); >>> ecore_x_window_show(inst->win.base); >> >> I really don't see how this could help, care to ellaborate? >> > > the short answer is that if you use ecore_x_window_new with an argb > parent window wrong window attributes will be set to the new window. > ecore_x_window_new copies the depth and visual from parent but does > not set the right colormap in attributes. this will e.g. cause a > BadMatch when doing ecore_x_window_background_color_set. it seems also > that tray icons dont like to be reparented to it, for which i dont > know the exact reason. if everything would work right here a new argb > window would be created but some tray icons seem not to like argb > parents at all. this way we create a plain rgb window and reparent it > to the shelf window.
weird! Anyway, better to fix ecore_x_window_new()? -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
