I will need to unpack / pack an object in eyelight-editor, so yes it is necessary :).
The code seems correct but I don't know the code of els_smart_box. Instead of "while (sd->items)" maybe we should use "EINA_LIST_FOREACH_SAFE(sd->items, l, l_next, child) ...". The current version has a infinite loop if _els_smart_box_unpack() failed. 2009/9/11 Marco Trevisan <[email protected]> > Gustavo Sverzut Barbieri wrote: > > On Fri, Sep 11, 2009 at 3:26 PM, "Marco Trevisan (Treviño)" > > <[email protected]> wrote: > >> Hello, I've often found useful to remove items from an elm_box, and the > >> new elm_box_clear function helps me a lot, by the way in some > >> circumstances I'd prefer not to delete the items I've packed in the box, > >> but just to unbox them. > >> > > > > I've not read the code and I guess the best one to do it is raster as > > he wrote the e_box used by elm_box... but my opinion is that it would > > be much better to move elm_box to use evas_object_box with pre-defined > > layout depending on whenever it's horizontal/vertical and homogeneous > > or not, simulate the pack start/end with append/prepend or deprecate > > the pack_* methods and just wrap around the evas one. It's more > > flexible and having a single source of bugs is better. > > I figure this is a good advice for redesigning the code of elm_box at all, > but > since yesterday raster pushed a commit for clearing a box content that uses > this > implementation, I followed him by adding new APIs which use the previously > written code to perform the unpacking tasks (needed, I think). > Also because I hope it could be merged soon :P, waiting for a better > implementation ;). > > > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus > on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Regards. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
