On Mon, Sep 21, 2009 at 1:36 PM, Enlightenment SVN <[email protected]> wrote: > Log: > * efreet: Use eina_log. > > Patch from Matthieu. > > Author: cedric > Date: 2009-09-21 09:36:29 -0700 (Mon, 21 Sep 2009) > New Revision: 42599 > > Modified: > trunk/efreet/AUTHORS trunk/efreet/src/lib/efreet.c > trunk/efreet/src/lib/efreet_base.c trunk/efreet/src/lib/efreet_base.h > trunk/efreet/src/lib/efreet_desktop.c trunk/efreet/src/lib/efreet_icon.c > trunk/efreet/src/lib/efreet_ini.c trunk/efreet/src/lib/efreet_menu.c > trunk/efreet/src/lib/efreet_mime.c trunk/efreet/src/lib/efreet_private.h > trunk/efreet/src/lib/efreet_trash.c trunk/efreet/src/lib/efreet_utils.c > trunk/efreet/src/lib/efreet_xml.c > > Modified: trunk/efreet/AUTHORS > =================================================================== > --- trunk/efreet/AUTHORS 2009-09-21 16:08:51 UTC (rev 42598) > +++ trunk/efreet/AUTHORS 2009-09-21 16:36:29 UTC (rev 42599) > @@ -4,3 +4,4 @@ > Nathan 'RbdPngn' Ingersoll > Nicholas 'Mekius' Hughart > Albin "Lutin" Tonnerre <[email protected]> > +Mathieu Taillefumier <[email protected]> > > Modified: trunk/efreet/src/lib/efreet.c > =================================================================== > --- trunk/efreet/src/lib/efreet.c 2009-09-21 16:08:51 UTC (rev 42598) > +++ trunk/efreet/src/lib/efreet.c 2009-09-21 16:36:29 UTC (rev 42599) > @@ -3,7 +3,7 @@ > #ifdef HAVE_CONFIG_H > # include <config.h> > #endif > - > +#include <stdio.h> > #include <string.h> > > #include <Ecore_Str.h> > @@ -17,7 +17,7 @@ > static char *efreet_lang = NULL; > static char *efreet_lang_country = NULL; > static char *efreet_lang_modifier = NULL; > - > +int _efreet_log_domain_global = -1; > static void efreet_parse_locale(void); > static int efreet_parse_locale_setting(const char *env); > > @@ -30,6 +30,12 @@ > { > if (init++) return init; > if (!eina_init()) return --init; > + _efreet_log_domain_global = > eina_log_domain_register("Efreet",EFREET_DEFAULT_LOG_COLOR); > + if(_efreet_log_domain_global < 0) > + { > + printf("Efreet could create a general log domain.\n"); > + return --init;
Nothing that would matter much, but for future patches add this printf() as EINA_LOG_ERROR() as not being able to register your domain does not mean you don't have logging at all. Also, for colors, I see you like cyan, but just use the EINA_COLOR_* to make it clear what color you're using, people may not understand what \033[0;36m is :-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
