Chances arde small that 2 composite managers (one of tghem bling) will be 
running at the same time. And if you disable bling, then it will be preferrable 
if that config option is turned off. I can't think of a single use case where 
this will cause problems. On the other hand, at the least it will save the user 
some actions by toggling this on their behalf.

-----Original Message-----
From: Dave Andreoli <[email protected]>
Sent: 22 September 2009 05:46
To: [email protected]
Cc: [email protected]
Subject: Re: [E-devel] E SVN: urandom trunk/E-MODULES-EXTRA/bling/src

2009/9/21 Enlightenment SVN <[email protected]>

> Log:
>  mirror init behaviour: disable "use_composite" when shutting down
>

Are you sure this is right?
The use_composite usage in init() is thinked as a 'one shot', executed only
the first time to
set a config required by bling.
I don't think is a good idea to switch use_composite on every
boot/shoutdown.
:/


>
> Author:       urandom
> Date:         2009-09-21 14:00:08 -0700 (Mon, 21 Sep 2009)
> New Revision: 42608
>
> Modified:
>  trunk/E-MODULES-EXTRA/bling/src/e_mod_main.c
>
> Modified: trunk/E-MODULES-EXTRA/bling/src/e_mod_main.c
> ===================================================================
> --- trunk/E-MODULES-EXTRA/bling/src/e_mod_main.c        2009-09-21 20:36:35
> UTC (rev 42607)
> +++ trunk/E-MODULES-EXTRA/bling/src/e_mod_main.c        2009-09-21 21:00:08
> UTC (rev 42608)
> @@ -83,6 +83,12 @@
>  _bling_shutdown(Bling *b)
>  {
>    composite_shutdown();
> +   if (e_config->use_composite)
> +     {
> +        e_config->use_composite = 0;
> +        e_config_save_queue();
> +     }
> +
>    b->module = NULL;
>    free(b->config);
>    E_CONFIG_DD_FREE(b->conf_edd);
>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> enlightenment-svn mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to