Hey, > On Wed, 23 Sep 2009, Vincent Torri wrote: > > >> >> On Tue, 22 Sep 2009, Gustavo Sverzut Barbieri wrote: >> >> >>> On Tue, Sep 22, 2009 at 8:01 PM, Vincent Torri<[email protected]> wrote: >>> >>>> Hey, >>>> >>>> ERROR is a macro that is already defined in Windows headers. Why isn't >>>> there a namespace ? namespace are for that : avoid duplicating names. >>>> >>> it should be internal >>> >> and ? >> >> >>> and as a macro no real need to namespace it as >>> it will not end in binaries... I recommend using ERR instead of ERROR >>> (all 3 letters, like INF, WRN...) >>> >> same problem can occurs with inclusion of standard headers that redefine >> the macro. >> >> The problem here is in software_ddraw. In evas_outbuf.c, where ERROR is >> used, evas_engine.h is included after evas_common.h. And evas_engine.h >> includes indirectly wingdi.h which redefines ERROR. >> > look in evas_common.h : ERR and ERROR are defined > I thought it was better to define two set of macros one for the lib and one the module when I started to write the code but I actually did not think that it might used by system header files (especially windows). So a solution would be to renam ERROR -> EVAS_ERROR, etc... and the macors defined for the modules as EVAS_MOD_ERR to avoid confusion.
Mathieu ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
