On Sat, 7 Nov 2009, Gustavo Sverzut Barbieri wrote:

On Sat, Nov 7, 2009 at 5:09 AM, Enlightenment SVN
<[email protected]> wrote:
Log:
 use static buffer

Author:       caro
Date:         2009-11-06 23:09:06 -0800 (Fri, 06 Nov 2009)
New Revision: 43510

Modified:
 trunk/ecore/src/lib/ecore_con/ecore_con_url.c

Modified: trunk/ecore/src/lib/ecore_con/ecore_con_url.c
===================================================================
--- trunk/ecore/src/lib/ecore_con/ecore_con_url.c       2009-11-07 05:58:01 UTC 
(rev 43509)
+++ trunk/ecore/src/lib/ecore_con/ecore_con_url.c       2009-11-07 07:09:06 UTC 
(rev 43510)
@@ -774,10 +774,9 @@
   if (!url_con->url) return 0;
   if (filename)
     {
-       char *tmp;
+       char tmp[PATH_MAX];

-       tmp = strdup(filename);
-       if (!tmp) return 0;
+       snprintf(tmp, PATH_MAX, "%s", filename);

ecore_strlcpy() is bit faster :-) do not change this one, but consider
for next ;-)

i'm sure that we can replace plenty of snprintf calls like that with strlcpy, actually. Maybe that's something to do before the release :)

Vincent
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to